From ab8998cdf26f1db38ac14df0f2c9596c9c22b246 Mon Sep 17 00:00:00 2001
From: Peter Stuifzand <peter@stuifzand.eu>
Date: Sat, 15 Sep 2018 16:07:28 +0200
Subject: [PATCH] Extract method setCachedTokenResponseValue

---
 cmd/eksterd/auth.go | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/cmd/eksterd/auth.go b/cmd/eksterd/auth.go
index 90480be..ac9a54f 100644
--- a/cmd/eksterd/auth.go
+++ b/cmd/eksterd/auth.go
@@ -51,11 +51,19 @@ func (b *memoryBackend) cachedCheckAuthToken(conn redis.Conn, header string, r *
 	authorized := b.checkAuthToken(header, r)
 	if authorized {
 		fmt.Printf("Token response: %#v\n", r)
-		_, err = conn.Do("HMSET", redis.Args{}.Add(key).AddFlat(r)...)
-		if err != nil {
-			log.Printf("Error while setting token: %v\n", err)
-			return authorized
-		}
+		setCachedTokenResponseValue(err, conn, key, r)
+		return true
+	}
+
+	return authorized
+}
+
+// setCachedTokenResponseValue remembers the value of the auth token response in redis
+func setCachedTokenResponseValue(err error, conn redis.Conn, key string, r *auth.TokenResponse) {
+	_, err = conn.Do("HMSET", redis.Args{}.Add(key).AddFlat(r)...)
+	if err != nil {
+		log.Printf("Error while setting token: %v\n", err)
+	} else {
 		_, err = conn.Do("EXPIRE", key, uint64(10*time.Minute/time.Second))
 		if err != nil {
 			log.Printf("Error while setting expire on token: %v\n", err)
@@ -64,11 +72,8 @@ func (b *memoryBackend) cachedCheckAuthToken(conn redis.Conn, header string, r *
 			if err != nil {
 				log.Printf("Deleting token failed: %v", err)
 			}
-			return authorized
 		}
 	}
-
-	return authorized
 }
 
 func getCachedValue(err error, conn redis.Conn, key string, r *auth.TokenResponse) (bool, error) {