Improve notifications

cmd/eksterd/memory.go

@@ -231,9 +231,6 @@ func (b *memoryBackend) ChannelsCreate(name string) (microsub.Channel, error) {
 func (b *memoryBackend) ChannelsUpdate(uid, name string) (microsub.Channel, error) {
 	defer b.save()
 
-	b.lock.RLock()
-	defer b.lock.RUnlock()
-
 	b.lock.RLock()
 	c, e := b.Channels[uid]
 	b.lock.RUnlock()
@@ -290,18 +287,21 @@ func (b *memoryBackend) run() {
 			case <-b.ticker.C:
 				feeds := b.getFeeds()
 
+				count := 0
+
 				for uid := range feeds {
 					for _, feedURL := range feeds[uid] {
 						resp, err := b.Fetch3(uid, feedURL)
 						if err != nil {
 							_ = b.channelAddItem("notifications", microsub.Item{
 								Type: "entry",
-								Name: fmt.Sprintf("Error while Fetch3 of %s: %v", feedURL, err),
+								Name: "Error while fetching feed",
 								Content: &microsub.Content{
-									Text: "error while fetching feed",
+									Text: fmt.Sprintf("Error while updating feed %s: %v", feedURL, err),
 								},
 								UID: time.Now().String(),
 							})
+							count++
 							log.Printf("Error while Fetch3 of %s: %v\n", feedURL, err)
 							continue
 						}
@@ -310,6 +310,10 @@ func (b *memoryBackend) run() {
 					}
 				}
 
+				if count > 0 {
+					_ = b.updateChannelUnreadCount("notifications")
+				}
+
 			case <-b.quit:
 				b.ticker.Stop()
 				return
@@ -346,12 +350,13 @@ func (b *memoryBackend) FollowURL(uid string, url string) (microsub.Feed, error)
 	if err != nil {
 		_ = b.channelAddItem("notifications", microsub.Item{
 			Type: "entry",
-			Name: fmt.Sprintf("Error while Fetch3 of %s: %v", feed.URL, err),
+			Name: "Error while fetching feed",
 			Content: &microsub.Content{
-				Text: "error while fetching feed",
+				Text: fmt.Sprintf("Error while Fetch3 of %s: %v", feed.URL, err),
 			},
 			UID: time.Now().String(),
 		})
+		_ = b.updateChannelUnreadCount("notifications")
 		return feed, err
 	}
 	defer resp.Body.Close()