diff --git a/models/issue_dependency.go b/models/issue_dependency.go index 3840c18f4..6590f5656 100644 --- a/models/issue_dependency.go +++ b/models/issue_dependency.go @@ -46,7 +46,7 @@ func CreateIssueDependency(user *User, issue, dep *Issue) (err error) { return ErrDependencyExists{issue.ID, dep.ID} } // And if it would be circular - circular, err := issueDepIsCircular(sess, issue.ID, dep.ID) + circular, err := issueDepExists(sess, dep.ID, issue.ID) if err != nil { return err } @@ -137,12 +137,6 @@ func issueDepExists(e Engine, issueID int64, depID int64) (exists bool, err erro return } -// Checks if a dependency is circular -func issueDepIsCircular(e Engine, issueID int64, depID int64) (circular bool, err error) { - circular, err = e.Where("issue_id = ? AND dependency_id = ?", depID, issueID).Exist(&IssueDependency{}) - return -} - // IssueNoDependenciesLeft checks if issue can be closed func IssueNoDependenciesLeft(issue *Issue) (bool, error) {