From 561f459364d82c568a3ee8cc4f39d3d50847fa51 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Wed, 30 May 2018 17:46:31 +0200 Subject: [PATCH] Fix #4081 Check for leading / in base before removing it (#4083) --- modules/markup/html.go | 4 ++-- modules/markup/html_test.go | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/markup/html.go b/modules/markup/html.go index d4d1bc5c6..383525477 100644 --- a/modules/markup/html.go +++ b/modules/markup/html.go @@ -129,8 +129,8 @@ func URLJoin(base string, elems ...string) string { return "" } joinedURL := baseURL.ResolveReference(argURL).String() - if !baseURL.IsAbs() { - return joinedURL[1:] // Removing leading '/' + if !baseURL.IsAbs() && !strings.HasPrefix(base, "/") { + return joinedURL[1:] // Removing leading '/' if needed } return joinedURL } diff --git a/modules/markup/html_test.go b/modules/markup/html_test.go index e475e575e..e269041fd 100644 --- a/modules/markup/html_test.go +++ b/modules/markup/html_test.go @@ -85,6 +85,12 @@ func TestURLJoin(t *testing.T) { "a/", "b/c/", "/../d/"), newTest("https://try.gitea.io/a/b/c#d", "https://try.gitea.io", "a/b", "c#d"), + newTest("/a/b/d", + "/a/", "b/c/", "/../d/"), + newTest("/a/b/c", + "/a", "b/c/"), + newTest("/a/b/c#hash", + "/a", "b/c#hash"), } { assert.Equal(t, test.Expected, URLJoin(test.Base, test.Elements...)) }