From 63ce7d0f82eab90d36c93f35b5839002b3aa436b Mon Sep 17 00:00:00 2001 From: Konrad Langenberg Date: Tue, 3 Oct 2017 15:27:06 +0200 Subject: [PATCH] Optimized Issue Dependency Left Signed-off-by: Konrad --- models/issue_dependency.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/models/issue_dependency.go b/models/issue_dependency.go index 35b1f2e16..3ff620a8c 100644 --- a/models/issue_dependency.go +++ b/models/issue_dependency.go @@ -141,17 +141,17 @@ func (IssueDependencyIssue) TableName() string { // IssueNoDependenciesLeft checks if issue can be closed func IssueNoDependenciesLeft(issue *Issue) bool { - total, err := x. + exists, err := x. Join("INNER", "issue", "issue.id = issue_dependency.issue_id"). Where("issue_dependency.issue_id = ?", issue.ID). And("issue.is_closed = ?", "0"). - Count(&IssueDependencyIssue{}) + Exist(&IssueDependencyIssue{}) if err != nil { return false } - if total > 0 { + if exists{ return false }