From 79f0315289ffae04319977941dc8d8dd6c34f34a Mon Sep 17 00:00:00 2001 From: Konrad Langenberg Date: Tue, 3 Oct 2017 15:00:31 +0200 Subject: [PATCH] Improved Check for dependencies left Signed-off-by: Konrad --- models/issue_dependency.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/models/issue_dependency.go b/models/issue_dependency.go index d71520348..35b1f2e16 100644 --- a/models/issue_dependency.go +++ b/models/issue_dependency.go @@ -141,13 +141,11 @@ func (IssueDependencyIssue) TableName() string { // IssueNoDependenciesLeft checks if issue can be closed func IssueNoDependenciesLeft(issue *Issue) bool { - issueDeps := new(IssueDependencyIssue) - total, err := x. Join("INNER", "issue", "issue.id = issue_dependency.issue_id"). Where("issue_dependency.issue_id = ?", issue.ID). And("issue.is_closed = ?", "0"). - Count(issueDeps) + Count(&IssueDependencyIssue{}) if err != nil { return false