From 82129b85e9a31ddc39ad0cd09e120488fa881e23 Mon Sep 17 00:00:00 2001 From: kolaente Date: Tue, 17 Apr 2018 18:48:13 +0200 Subject: [PATCH] Simplified returning blocked/blocking dependencies --- models/issue.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/models/issue.go b/models/issue.go index 4811e11ec..a620b5f6b 100644 --- a/models/issue.go +++ b/models/issue.go @@ -1515,26 +1515,22 @@ func UpdateIssue(issue *Issue) error { // Get Blocked By Dependencies, aka all issues this issue is blocked by. func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*Issue, err error) { - err = e. + return issueDeps, e. Table("issue_dependency"). Select("issue.*"). Join("INNER", "issue", "issue.id = issue_dependency.dependency_id"). Where("issue_id = ?", issue.ID). Find(&issueDeps) - - return } // Get Blocking Dependencies, aka all issues this issue blocks. func (issue *Issue) getBlockingDependencies(e Engine) (issueDeps []*Issue, err error) { - err = e. + return issueDeps, e. Table("issue_dependency"). Select("issue.*"). Join("INNER", "issue", "issue.id = issue_dependency.issue_id"). Where("dependency_id = ?", issue.ID). Find(&issueDeps) - - return } // BlockedByDependencies finds all Dependencies an issue is blocked by