From 837c917798d6e7fb959b47d75f8757fa32c869d4 Mon Sep 17 00:00:00 2001
From: Konrad Langenberg <konrad@kola-entertainments.de>
Date: Sun, 24 Sep 2017 16:27:50 +0200
Subject: [PATCH] Moved error check before range

Signed-off-by: Konrad <konrad@kola-entertainments.de>
---
 models/issue_dependency.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/models/issue_dependency.go b/models/issue_dependency.go
index ca6c4e23b..214ac7fbe 100644
--- a/models/issue_dependency.go
+++ b/models/issue_dependency.go
@@ -139,6 +139,10 @@ func IssueNoDependenciesLeft(issue *Issue) bool {
 	var issueDeps []IssueDependencyIssue
 
 	err := x.Join("INNER", "issue", "issue.id = issue_dependency.issue_id").Find(&issueDeps)
+	
+	if err != nil {
+		return false
+	}
 
 	for _, issueDep := range issueDeps {
 		if !issueDep.IsClosed {
@@ -146,9 +150,5 @@ func IssueNoDependenciesLeft(issue *Issue) bool {
 		}
 	}
 
-	if err != nil {
-		return false
-	}
-
 	return true
 }