From be7663103bd5a5450f0fe283d75825beecff0109 Mon Sep 17 00:00:00 2001 From: kolaente Date: Mon, 16 Apr 2018 19:15:14 +0200 Subject: [PATCH] Improvements when returning an error. --- models/issue.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/models/issue.go b/models/issue.go index 53dec6fe5..4811e11ec 100644 --- a/models/issue.go +++ b/models/issue.go @@ -1515,28 +1515,24 @@ func UpdateIssue(issue *Issue) error { // Get Blocked By Dependencies, aka all issues this issue is blocked by. func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*Issue, err error) { - if err = e. + err = e. Table("issue_dependency"). Select("issue.*"). Join("INNER", "issue", "issue.id = issue_dependency.dependency_id"). Where("issue_id = ?", issue.ID). - Find(&issueDeps); err != nil { - return issueDeps, err - } + Find(&issueDeps) return } // Get Blocking Dependencies, aka all issues this issue blocks. func (issue *Issue) getBlockingDependencies(e Engine) (issueDeps []*Issue, err error) { - if err := e. + err = e. Table("issue_dependency"). Select("issue.*"). Join("INNER", "issue", "issue.id = issue_dependency.issue_id"). Where("dependency_id = ?", issue.ID). - Find(&issueDeps); err != nil { - return issueDeps, err - } + Find(&issueDeps) return }