peter/go-gitea
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

simplified depExists method

Browse Source 
Signed-off-by: Konrad <konrad@kola-entertainments.de>
This commit is contained in:
Konrad Langenberg 2017-09-23 14:59:31 +02:00 committed by Konrad
parent 1f8ce67366
commit f707d54598
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
models/issue_dependency.go
View File

@ -123,27 +123,15 @@ func RemoveIssueDependency(user *User, issue *Issue, dep *Issue, depType int64)
// Check if the dependency already exists
func issueDepExists(e Engine, issueID int64, depID int64) (exists bool, err error) {
var Dependencies = IssueDependency{IssueID: issueID, DependencyID: depID}
exists, err = e.Get(&Dependencies)
deps := new(IssueDependency)
exists, err = e.Where("(issue_id = ? AND dependency_id = ?) OR (issue_id = ? AND dependency_id = ?)", issueID, depID, depID, issueID).Get(deps)
if err != nil {
return exists, err
}
// Check for dependencies the other way around
// Otherwise two issues could block each other which would result in none of them could be closed.
if !exists {
Dependencies.IssueID = depID
Dependencies.DependencyID = issueID
exists, err = e.Get(&Dependencies)
if err != nil {
return exists, err
}
}
return
return exists, nil
}
// IssueNoDependenciesLeft checks if issue can be closed