peter/track-me
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve session tests

Browse Source
This commit is contained in:
Peter Stuifzand 2018-10-02 22:24:18 +02:00
parent 048c474cf6
commit 9b306c71a9
5 changed files with 64 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
index.go
View File

@ -113,6 +113,7 @@ type indexHandler struct {
func (h *indexHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (h *indexHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
sess, err := NewSession(w, r) sess, err := NewSession(w, r)
if err != nil { if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
log.Printf("Error loading session: %s", err) log.Printf("Error loading session: %s", err)
return return
} }
@ -125,7 +126,9 @@ func (h *indexHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
moments, err := loadMoments(h.DB, time.Now().Format("2006-01-02")) moments, err := loadMoments(h.DB, time.Now().Format("2006-01-02"))
if err != nil { if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
log.Println(err) log.Println(err)
return
} }
type indexPageInfo struct { type indexPageInfo struct {
@ -145,12 +148,14 @@ func (h *indexHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
t, err := template.New("index").Parse(IndexPageTemplate) t, err := template.New("index").Parse(IndexPageTemplate)
if err != nil { if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
log.Println(err) log.Println(err)
return return
} }
err = t.Execute(w, indexPage) err = t.Execute(w, indexPage)
if err != nil { if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
log.Println(err) log.Println(err)
return return
} }

12
indieauth.go
View File

@ -21,20 +21,20 @@ func performIndieauthCallback(state, code string, sess *Session) (bool, *indieau
} }
func (h *IndieAuthHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (h *IndieAuthHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
log.Println(r.URL.Path)
sess, err := NewSession(w, r) sess, err := NewSession(w, r)
if err != nil { if err != nil {
http.Error(w, err.Error(), 500) http.Error(w, err.Error(), 500)
return return
} }
defer sess.Flush() defer sess.Flush()
if sess.LoggedIn {
http.Redirect(w, r, "/", 302)
return
}
if r.Method == http.MethodGet { if r.Method == http.MethodGet {
if sess.LoggedIn {
http.Redirect(w, r, "/", 302)
return
}
if r.URL.Path == "" { if r.URL.Path == "" {
fmt.Fprint(w, `<!doctype html> fmt.Fprint(w, `<!doctype html>
<html> <html>

4
main.go
View File

@ -9,6 +9,10 @@ import (
bolt "go.etcd.io/bbolt" bolt "go.etcd.io/bbolt"
) )
func init() {
log.SetFlags(log.LstdFlags|log.Lshortfile)
}
const DBFilename = "./moments.db" const DBFilename = "./moments.db"
// Moment is the main information this servers remembers // Moment is the main information this servers remembers

1
session.go
View File

@ -78,6 +78,7 @@ func getSessionCookie(w http.ResponseWriter, r *http.Request) (string, error) {
Name: "session", Name: "session",
Value: sessionVar, Value: sessionVar,
Expires: time.Now().Add(24 * time.Hour), Expires: time.Now().Add(24 * time.Hour),
Path: "/",
} }
http.SetCookie(w, newCookie) http.SetCookie(w, newCookie)

49
session_test.go
View File

@ -24,6 +24,9 @@ func TestGetSessionCookieMissingCookie(t *testing.T) {
if c.Value != sessionKey { if c.Value != sessionKey {
t.Errorf("Wrong sessionKey %q != %q", c.Value, sessionKey) t.Errorf("Wrong sessionKey %q != %q", c.Value, sessionKey)
} }
if c.Path != "/" {
t.Errorf("Wrong cookiepath %q != %q", c.Path, "/")
}
break break
} }
} }
@ -33,7 +36,7 @@ func TestGetSessionCookieCookieSet(t *testing.T) {
mySessionKey := "12341234" mySessionKey := "12341234"
r, _ := http.NewRequest("GET", "/", nil) r, _ := http.NewRequest("GET", "/", nil)
cookie := &http.Cookie{Name: "session", Value: mySessionKey} cookie := &http.Cookie{Name: "session", Value: mySessionKey, Path: r.URL.Path}
r.AddCookie(cookie) r.AddCookie(cookie)
w := httptest.NewRecorder() w := httptest.NewRecorder()
@ -45,4 +48,48 @@ func TestGetSessionCookieCookieSet(t *testing.T) {
if mySessionKey != sessionKey { if mySessionKey != sessionKey {
t.Errorf("getSessionKey didn't fetch sessionKey from \"session\" cookie") t.Errorf("getSessionKey didn't fetch sessionKey from \"session\" cookie")
} }
cookies := w.Result().Cookies()
for _, c := range cookies {
if c.Name == "session" {
if c.Value != sessionKey {
t.Errorf("Wrong sessionKey %q != %q", c.Value, sessionKey)
}
if c.Path != "" {
t.Errorf("Wrong cookiepath %q != %q", c.Path, "")
}
break
}
}
}
func TestGetSessionCookieCookieSetAuth(t *testing.T) {
mySessionKey := "12341234"
r, _ := http.NewRequest("GET", "/auth/", nil)
cookie := &http.Cookie{Name: "session", Value: mySessionKey, Path: r.URL.Path}
r.AddCookie(cookie)
w := httptest.NewRecorder()
sessionKey, err := getSessionCookie(w, r)
if err != nil {
t.Errorf("err != nil in getSessionCookie")
}
if mySessionKey != sessionKey {
t.Errorf("getSessionKey didn't fetch sessionKey from \"session\" cookie")
}
cookies := w.Result().Cookies()
for _, c := range cookies {
if c.Name == "session" {
if c.Value != sessionKey {
t.Errorf("Wrong sessionKey %q != %q", c.Value, sessionKey)
}
if c.Path != "" {
t.Errorf("Wrong cookiepath %q != %q", c.Path, "")
}
break
}
}
} }