peter/go-gitea
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Moved error check before range

Browse Source 
Signed-off-by: Konrad <konrad@kola-entertainments.de>
This commit is contained in:
Konrad Langenberg 2017-09-24 16:27:50 +02:00 committed by Konrad
parent e58f703b08
commit 837c917798
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
models/issue_dependency.go
View File

@ -139,6 +139,10 @@ func IssueNoDependenciesLeft(issue *Issue) bool {
var issueDeps []IssueDependencyIssue
err := x.Join("INNER", "issue", "issue.id = issue_dependency.issue_id").Find(&issueDeps)
if err != nil {
return false
}
for _, issueDep := range issueDeps {
if !issueDep.IsClosed {
@ -146,9 +150,5 @@ func IssueNoDependenciesLeft(issue *Issue) bool {
}
}
if err != nil {
return false
}
return true
}