Improvements when returning an error.

This commit is contained in:
kolaente 2018-04-16 19:15:14 +02:00
parent 7528664a97
commit be7663103b
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B

View File

@ -1515,28 +1515,24 @@ func UpdateIssue(issue *Issue) error {
// Get Blocked By Dependencies, aka all issues this issue is blocked by.
func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*Issue, err error) {
if err = e.
err = e.
Table("issue_dependency").
Select("issue.*").
Join("INNER", "issue", "issue.id = issue_dependency.dependency_id").
Where("issue_id = ?", issue.ID).
Find(&issueDeps); err != nil {
return issueDeps, err
}
Find(&issueDeps)
return
}
// Get Blocking Dependencies, aka all issues this issue blocks.
func (issue *Issue) getBlockingDependencies(e Engine) (issueDeps []*Issue, err error) {
if err := e.
err = e.
Table("issue_dependency").
Select("issue.*").
Join("INNER", "issue", "issue.id = issue_dependency.issue_id").
Where("dependency_id = ?", issue.ID).
Find(&issueDeps); err != nil {
return issueDeps, err
}
Find(&issueDeps)
return
}