peter/go-gitea
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improvements when returning an error.

Browse Source
This commit is contained in:
kolaente 2018-04-16 19:15:14 +02:00
parent 7528664a97
commit be7663103b
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
models/issue.go
View File

@ -1515,28 +1515,24 @@ func UpdateIssue(issue *Issue) error {
// Get Blocked By Dependencies, aka all issues this issue is blocked by. // Get Blocked By Dependencies, aka all issues this issue is blocked by.
func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*Issue, err error) { func (issue *Issue) getBlockedByDependencies(e Engine) (issueDeps []*Issue, err error) {
if err = e. err = e.
Table("issue_dependency"). Table("issue_dependency").
Select("issue.*"). Select("issue.*").
Join("INNER", "issue", "issue.id = issue_dependency.dependency_id"). Join("INNER", "issue", "issue.id = issue_dependency.dependency_id").
Where("issue_id = ?", issue.ID). Where("issue_id = ?", issue.ID).
Find(&issueDeps); err != nil { Find(&issueDeps)
return issueDeps, err
}
return return
} }
// Get Blocking Dependencies, aka all issues this issue blocks. // Get Blocking Dependencies, aka all issues this issue blocks.
func (issue *Issue) getBlockingDependencies(e Engine) (issueDeps []*Issue, err error) { func (issue *Issue) getBlockingDependencies(e Engine) (issueDeps []*Issue, err error) {
if err := e. err = e.
Table("issue_dependency"). Table("issue_dependency").
Select("issue.*"). Select("issue.*").
Join("INNER", "issue", "issue.id = issue_dependency.issue_id"). Join("INNER", "issue", "issue.id = issue_dependency.issue_id").
Where("dependency_id = ?", issue.ID). Where("dependency_id = ?", issue.ID).
Find(&issueDeps); err != nil { Find(&issueDeps)
return issueDeps, err
}
return return
} }